On 15/12/2022 13:34, Neal Gompa wrote:
That stopped working several releases ago.
It should be fixed then. Please report this issue to dnf component.
Some suggestions for current implementation:
1. Please rewrite the first run script from Bash to Python. Running bash
scripts as root is extremely dangerous. One mistake or empty variable
can cause a disaster.
Example: rm -rf /usr/$foo. If the $foo variable is empty, it will wipe
the entire /usr. Also everyone can inject any commands and execute them
as root. Example: $foo = '; curl .... | bash'.
2. Please do a network presence check before doing anything. Most users
store Wi-Fi passwords in a KDE/GNOME keyring and there is no network
access during the boot. The script will fail instantly.
3. Please check if the full ffmpeg-libs or libavcodec-freeworld are
installed. In such configurations, OpenH264 is not needed.
4. Please implement an opt-out switch. Some users don't want openh264
from Cisco's third-party repository to be installed.
--
Sincerely,
Vitaly Zaitsev (vitaly@xxxxxxxxxxxxxx)
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
