Re: Review Request: ImageMagick7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2022-12-03 at 17:41 +0100, Kalev Lember wrote:
On Sat, Dec 3, 2022 at 5:38 PM Neal Gompa <ngompa13@xxxxxxxxx> wrote:
On Sat, Dec 3, 2022 at 11:34 AM Kalev Lember <kalevlember@xxxxxxxxx> wrote:
>
> On Sat, Dec 3, 2022 at 5:26 PM Sérgio Basto <sergio@xxxxxxxxxx> wrote:
>>
>> On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote:
>> > On 03/12/2022 00:30, Sérgio Basto wrote:
>> > > The proposal now is to keep ImageMagick 6 and make a new package
>> > > with
>> > > ImageMagick 7 , when we have all applications use only ImageMagick
>> > > 7,
>> > > we move the sources from ImageMagick7 to ImageMagick
>> >
>> > I think it would be better to update the ImageMagick package to
>> > version
>> > 7 and create a compatibility package ImageMagick6.
>>
>> Anyone is going to review the package or not ?
>>
>> I already explain the situation in the other emails on this thread .
>>
>> I estimate that I will need about 200 hours to do what your brilliants
>> minds ask .
>>
>> And btw, asking to the others to have the work that you maybe don't
>> have in your packages , is very easy. if I do the compat package and
>> wait for 200 packages dependency adapt to the change, will be a chaos ,
>> and I don't like ignore all the tickets opened around it.
>>
>> ImageMagick-7.0.1-10 was release on 2016-06-07, today is 2022-12-03 so
>> after 6 Years and 5 Months and 26 Days, we still haven't  any
>> ImageMagick 7 in Fedora or EL, so or you help me on do it in my way ,
>> or I won't do it .
>>
>> That is why package guidelines should be a guide and not all  and not
>> the all truth rule, when in practice you don't follow it just claim it.
>
>
> I think it makes sense to do it the way Sergio is planning as it makes it all much much easier. I don't think we should set a too high bar here wrt the package naming; anything is an improvement if we can start getting the distro migrating to ImageMagick 7.
>
> We can always rename ImageMagick -> ImageMagick6 and ImageMagick7 -> ImageMagick at a later date when someone has the energy to do it.
>
> Don't let perfect be the enemy of good :)
>

It matters in this case because both packages provide stuff in
/usr/bin, and we only should have one provider of those. ImageMagick
should retain them, and the ImageMagick6 compat package should only
provide libraries for stuff that can't link to the IM7 libraries.


Ah, yes, that's a good point. I think we have a bunch of packages that 'BuildRequires: ImageMagick' and then use /usr/bin/convert during the build to convert icons from one format to another. Other packages require /usr/bin/convert for runtime use.

Sergio, what's your plan for handling /usr/bin/convert?


Thank you Kalev , 

I don't indent change /usr/bin/convert from ImageMagick6 so probably it will /usr/bin/convert-7 

Note that I checked Remi package and copied some ideas from there, so also should check how Remi handle this . 

-- 
Kalev
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

-- 
Sérgio M. B.
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux