Dne 15. 11. 22 v 10:44 Daniel P. Berrangé napsal(a):
Interestingly when I run 'license-fedora2spdx MIT' is just always prints 'mpich2', and the list of suggestions is entirely reversed from what you show here. Why 'mpich2' - it is simply because it is last in the list to be loaded. This is rather misleading and unhelpful IMHO.
Yes. Just first one in the list.
In that case, IMHO, the tool should NOT suggest a license from the list at all, and definitely not arbitrarily suggest the last one it loaded, which is highly likely to be wrong. If it wants to suggest, then suggest the most likely option out of the variants. Or can it suggest an intentionally invalid placeholder eg "{MIT choice}" to make it explicit that the maintainer has to actively make a choice. $ license-fedora2spdx "(GPLv2 or MIT or BSD)" Warning: more options how to interpret MIT. Possible options: ['Adobe-Glyph', 'BSL-1.0', 'BSL-1.0', 'HPND', 'HPND', 'ICU', 'MIT-CMU', 'MIT-Modern-Variant', 'MIT-enna', 'MIT-feh', 'MIT-open-group', 'MIT', 'NTP', 'SGI-B-2.0', 'SMLNJ', 'SMLNJ', 'libtiff', 'libtiff', 'mpich2'] Warning: more options how to interpret BSD. Possible options: ['BSD-2-Clause-FreeBSD', 'BSD-2-Clause-Views', 'BSD-2-Clause', 'BSD-3-Clause', 'BSD-3-Clause', 'BSD-3-Clause', 'BSD-3-Clause'] ( GPL-2.0-only OR {{pick MIT choice}} OR {{pick BSD choice}} )
Good idea. I will try to implement it. Thank you. Miroslav _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue