Resuming this thread as the podman and podman-desktop teams are looking to get podman-desktop packaged in Fedora But it's unlikely either team would be able to own the nodejs-electron dep. Would the nodejs sig and/or fedora desktop team and/or chromium maintainers be willing to package and own nodejs-electron? There's an open github issue pointing to this thread but that may not get enough Fedora eyes so I'm checking back here. (See: https://github.com/containers/podman-desktop/issues/112) On Sun, Mar 27, 2022 at 3:38 PM Sérgio Basto <sergio@xxxxxxxxxx> wrote: > > On Sun, 2022-03-27 at 14:52 -0400, Neal Gompa wrote: > > On Sun, Mar 27, 2022 at 2:42 PM Sérgio Basto <sergio@xxxxxxxxxx> wrote: > > > > > > On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote: > > > > On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel > > > > wrote: > > > > > On 27/02/2022 08:23, Andreas Schneider wrote: > > > > > > > > > > > You don't have to. You can point electron builder to your > > > > > > system > > > > > > electron > > > > > > and > > > > it will use that. Then you just do not package the electron files. > > > > > > All you need is the resources directory. > > > > > > > > > > > > > > > You must run electron-builder on Fedora Koji. Pre-built packages > > > > > are > > > > > not > > > > > allowed. > > > > > > > > You should not package electron at all with your package! You > > > > should > > > > use the > > > > nodejs-electron in the distribution and just point it to the > > > > sources to > > > > load: > > > > > > > > cat <<EOF >%{buildroot}%{_bindir}/signal-desktop > > > > #!/bin/sh > > > > export NODE_ENV=production > > > > > > > > exec %{_bindir}/electron %{_libdir}/%{name}/resources/app.asar > > > > "\$@" > > > > EOF > > > > chmod +x %{buildroot}%{_bindir}/signal-desktop > > > > > > I started build electron on copr [1] > > > > > > I built ffmpeg , nodejs-electron, element-web and element-desktop > > > for > > > Fedora 34 and 35 successfully element-web fails on F36+ > > > > > > I rebuilt ffmpeg-free from Fedora to F35 and F34 > > > after I used > > > https://build.opensuse.org/package/show/network:im:signal/nodejs-electron > > > https://build.opensuse.org/package/show/devel:languages:javascript/element-web > > > https://build.opensuse.org/package/show/home:sergiomb/element-desktop > > > > > > > > > build on electron took 11 hours on x64 and 15 hours in aarch , is > > > almost a build o chromium , which make me wonder if we can't use a > > > chromium as a library > > > https://www.electronjs.org/blog/electron-internals-building-chromium-as-a-library > > > > > > > libchromiumcontent hasn't been a thing in a *very* long time. It was > > merged into Electron in Electron 4.0 (which was years ago!) and it's > > all built as one runtime environment binary. > > > > But, one thing that could be done to simplify things would be to ship > > a chromium-src-devel package in the chromium package that electron > > could pull in. That would tightly couple the chromium and electron > > packages, but it would mean that improvements we make to the chromium > > package would be easily consumed by electron... > > > > yes, I think that should be the path and and I'd love see that done , > also for other projects like nwjs (node-webkit) > https://github.com/nwjs/nw.js , doesn't make sense to me build chromium > all the times , mainly because chromium takes hours and hours to build > and consumes a lot and a lot of resources. > > > I'm not sure we *want* to do that, but I have seen that done before > > for Electron packaging... > > > > > > -- > > 真実はいつも一つ！/ Always, there's only one truth! > > _______________________________________________ > > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > > Fedora Code of Conduct: > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: > > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > > Do not reply to spam on the list, report it: > > https://pagure.io/fedora-infrastructure > > -- > Sérgio M. B. > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure -- Lokesh Libera, GitLab, GitHub, Fedora: lsm5 Matrix: @lsm5:lsm5.ems.host GPG: 0xC7C3A0DD https://keybase.io/lsm5 _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
