On 05-09-2022 19:17, Miro Hrončok wrote:
On 05. 09. 22 19:00, Sandro wrote:
I see the following errors in the build log of a fc36 build [1]:
ValueError: Globs did not match any module: pymunin
Going up it looks like the name of the package is not expanded and falls back
to UNKNOWN:
Successfully built UNKNOWN
However, the builds for fc37 and rawhide did succeed. I also tried a local mock
build for x86_64, but the result is the same.
I fail to grasp what's going on here.
[1]
https://download.copr.fedorainfracloud.org/results/gui1ty/PyMunin3/fedora-36-armhfp/04809614-python-PyMunin3/
Looking at the project https://pypi.org/project/PyMunin3/3.0.1/#files
They include metadata for setuptools in pyproject.toml only (PEP 621):
https://github.com/penguinpee/PyMunin3/blob/v3.0.1/pyproject.toml#L5
This has only been supported since setuptools 61.0.0:
https://setuptools.pypa.io/en/latest/history.html#v61-0-0
https://peps.python.org/pep-0621/
On Fedora 36, setuptools is 59.6 and it does not read/understand the
information from pyproject.toml.
Unfortunately, when no name or version is present, setuptools does the
UNKNOWN==0.0.0 thing:
https://github.com/pypa/setuptools/issues/2329
My guess is that when PyMunin3 started to use this feature:
https://github.com/penguinpee/PyMunin3/commit/3993dcaa5366da9d771575e8735dd5a7a2c13894
They should have changed the minimal required setuptools version in:
https://github.com/penguinpee/PyMunin3/blob/v3.0.1/pyproject.toml#L2
In fact:
https://github.com/penguinpee/PyMunin3/pull/3
To package PyMunin3 on Fedora 36, you might need to revert 3993dcaa5366 via a
patch or somebody would need to backport this feature to setuptools 59. That
might be non-trivial. Due to a significant amount of other braking changes,
updating setuptools in Fedora 36 to 61 is not very likely.
Thank you, Miro, for the explanation and the pull request. I remember
switching away from setup.cfg after being told that pyproject.toml is
the way forward. I must have missed the fact that this required a newer
minimum version of setuptools.
Since this package has yet to make its way into Fedora, I don't mind if
it's not available for F36. It will trickle down (or is it up?) from F37.
-- Sandro
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
