On Sat, 2022-07-23 at 11:09 +0100, Richard W.M. Jones wrote:
>
> > qemu-2:7.0.0-6.fc37.src
>
> I looked at the qemu sources and I can't see where they need pcre (or
> pcre2 for that matter) ... So I've no idea why the spec file
> BuildRequires pcre-static.
Behold, the glory of git:
[adamw@xps13k qemu (f36 %)]$ git log -S'pcre-static' --oneline --name-status
0835325 Introduce qemu-user-static sub-RPM
M qemu.spec
[adamw@xps13k qemu (f36 %)]$ git show 0835325
commit 0835325a86f807126145e310f014deb21ffb9207
Author: Daniel P. Berrange <berrange@xxxxxxxxxx>
Date: Wed Jul 13 13:42:21 2016 +0100
Introduce qemu-user-static sub-RPM
The i686 build of this is temp disabled due to fubar
glibc-static on i686
The hardended build macro is disabled due to fubar
rpm macros for static linking while hardened, but
the equivalent hardening is turned on manually.
Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
diff --git a/qemu.spec b/qemu.spec
index 2e81028..59b968e 100644
--- a/qemu.spec
+++ b/qemu.spec
@@ -21,6 +21,13 @@
%global kvm_package system-aarch64
%endif
+%global user_static 1
+# glibc static libs are fubar on i386
+# https://bugzilla.redhat.com/show_bug.cgi?id=1352625
+%ifarch %{?ix86}
+%global user_static 0
+%endif
+
%global have_kvm 0
%if 0%{?kvm_package:1}
%global have_kvm 1
@@ -38,6 +45,10 @@
%global have_xen 1
%endif
+# Temp hack for https://bugzilla.redhat.com/show_bug.cgi?id=1343892
+# We'll manually turn on hardened build later in this spec
+%undefine _hardened_build
+
# Release candidate version tracking
# global rcver rc5
%if 0%{?rcver:1}
@@ -49,7 +60,7 @@
Summary: QEMU is a FAST! processor emulator
Name: qemu
Version: 2.6.0
-Release: 4%{?rcrel}%{?dist}
+Release: 5%{?rcrel}%{?dist}
Epoch: 2
License: GPLv2+ and LGPLv2+ and BSD
Group: Development/Tools
@@ -247,6 +258,8 @@ BuildRequires: virglrenderer-devel
# qemu 2.6: Needed for gtk GL support
BuildRequires: mesa-libgbm-devel
+BuildRequires: glibc-static pcre-static glib2-static zlib-static
...
This of course begs a question: did qemu also have a non-static pcre
requirement at the time? But it seems not:
[adamw@xps13k qemu (f36 %)]$ git show 0835325:qemu.spec | grep pcre
BuildRequires: glibc-static pcre-static glib2-static zlib-static
so, I'm not sure why Daniel concluded this needs a BuildRequires on
pcre-static, but the obvious thing to do would be to ask him, I guess.
--
Adam Williamson
Fedora QA
IRC: adamw | Twitter: adamw_ha
https://www.happyassassin.net
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
