Re: Fix aarch64 build on embree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Hello team,
> >
> > What is the way to disable `-mss2 for aarch64 build in embree?
>
> I think you mean msse2, the build should be using the distro default C
> flags for builds so it shouldn't be an issue, if you fix the build to
> use the proper distro flags the problem should go away. Details in the
> docs:
>
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags
>
> > Spec file: https://src.fedoraproject.org/rpms/embree/blob/rawhide/f/embree.spec
> >
> > Scratch build result: https://koji.fedoraproject.org/koji/taskinfo?taskID=88867571

Completely not the right way to fix it, you're note actually supposed
to be overwriting the SSE levels set by the base project else it won't
run on older x86 devices either, but the below worked for me on a
scratch build. The aarch64 arch sets NEON by default so if you were
using the proper defaults you'd actually have gott hat anyway.

diff --git a/embree.spec b/embree.spec
index b2e6d8e..a9e8c91 100644
--- a/embree.spec
+++ b/embree.spec
@@ -92,6 +92,9 @@ export CXXFLAGS="%{optflags} -Wl,--as-needed"
         -DEMBREE_MAX_ISA=SSE4.2 \
 %else
         -DEMBREE_MAX_ISA=NONE \
+%endif
+%ifarch aarch64
+        -DEMBREE_MAX_ISA=NEON \
 %endif
        -DEMBREE_TUTORIALS=OFF
 %cmake_build
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux