Re: fedpkg request-side-tag: I don't understand "allowed_suffixes"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Richard W.M. Jones píše v So 18. 06. 2022 v 12:08 +0100:
> I thought I'd be nice and use a suffix for my side tag so it would be
> clear (not least to me!) which side tag was being used for the OCaml
> rebuild in Rawhide, but ...
> 
> $ fedpkg request-side-tag --help
> usage: fedpkg request-side-tag [-h] [--base-tag BASE_TAG] [--suffix
> SUFFIX]
> 
> options:
>   -h, --help           show this help message and exit
>   --base-tag BASE_TAG  name of base tag
>   --suffix SUFFIX      A suffix to be appended to the side tag name.
> The
>                        suffix must be allowed in Koji configuration.
> 
> $ fedpkg request-side-tag --suffix ocaml
> Could not execute request_side_tag: ocaml suffix is not allowed for
> sidetag
> 
> Looking at this it seems there's a hard-coded list of allowed
> suffixes.  I couldn't find where this is defined, but obviously
> "ocaml" ain't on the list so it's not getting in.
> 
> I don't understand this - what's it for?  Or do I have to request the
> ocaml is added to the list?
> 

The allowed suffixes are listed in Koji hub configuration (and the list
defaults to empty).

The reason for restricting it is that Koji hub is using the tag name
for checking policy. Allowing unrestricted strings in the tag name
could potentially allow e.g. building from SRPMs.

https://pagure.io/sidetag-koji-plugin/issue/7

Lubomír

> Rich.
> 
> -- 
> Richard Jones, Virtualization Group, Red Hat
> http://people.redhat.com/~rjones
> Read my programming and virtualization blog:
> http://rwmj.wordpress.com
> virt-builder quickly builds VMs from scratch
> http://libguestfs.org/virt-builder.1.html
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
> https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
> Do not reply to spam on the list, report it:
> https://pagure.io/fedora-infrastructure
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux