On Fri, Jun 3, 2022 at 11:25 AM Vít Ondruch <vondruch@xxxxxxxxxx> wrote: > > BTW isn't the `_flag_` prefix too generic? And also, the initial > underscore implies that this is internal macro which should ideally not > be used. So should it be rather removed or not? I agree that the "_flag_" prefix might be a little too generic, but what would be a better alternative? Maybe something like _optflag_, to match what they are "collected into" (i.e. %optflags)? Also, macro names with single leading underscores are *fine* (see also %_bindir, %_libdir, %_datadir, etc.). Those with *double* leading underscores are the ones that should be considered "internal" implementation details. Fabio _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure