On Thu, 2022-03-24 at 14:28 -0500, Richard Shaw wrote: > On Thu, Mar 24, 2022 at 1:36 PM Ben Cotton <bcotton@xxxxxxxxxx> wrote: > > > The Fedora Linux 35 Beta RC4 compose[1] is GO and will be shipped live > > on Tuesday, 29 March 2022. > > > > Fedora 36 obviously :) > > Anyway, I just tried to install it in VirtualBox and got the following odd > problem: > > [image: image.png] > > I may try increasing the virtual disk size as I assumed 8GB was enough just > to play around, but why is it trying to allocate space for swap when it > should be using zswap? Looking at it very quickly, it looks a lot like that particular calculation just doesn't take into account whether there's actually going to *be* a swap partition or not. It looks like it wasn't updated for the "don't create swap by default" change; the code was written before that, so it could safely just assume the automatic partitioning would create one. In more technical detail, the codepath is here: https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/ui/gui/spokes/storage.py#L622 note how we call `auto_swap = suggest_swap_size()` and include it in the calculation, just...unconditionally? `suggest_swap_size()` is just a number cruncher, it doesn't know or care whether a swap partition is actually going to be included either. So in this "needed space calculation" code we're just always leaving room for a swap partition, even if the default or specified partition layout wouldn't include one. At least, that's how it looks to me. I don't think this is new in F36, though, it's probably been this way all along. It should definitely be filed as a bug on anaconda. I guess I'll do that. -- Adam Williamson Fedora QA IRC: adamw | Twitter: adamw_ha https://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
