V Fri, Mar 11, 2022 at 11:32:51PM +0100, Fabio Valentini napsal(a): > On Fri, Mar 11, 2022 at 11:15 PM Michel Alexandre Salim > <salimma@xxxxxxxxxxxxxxxxx> wrote: > > > > On Fri, Mar 04, 2022 at 09:26:04AM -0500, Steven A. Falco wrote: > > > There is a new FTBFS for KiCad [1]. I filed an issue with KiCad [2] and got a comment from the project leader: > > > > > > This looks like cmake issue to me. For some reason cmake is creating an incorrect build folder: > > > > > This is probably related: in cmake 3.22 (Fedora 36) and below, this > > works: > > > > ``` > > mkdir some-dir > > cd some-dir > > %cmake .. > > cd - > > > > mkdir other-dir > > cd other-dir > > %cmake .. > > cd - > > ``` > > > > Which is useful if you need to invoke `%cmake` several times, e.g. to > > build against different Lua runtimes (e.g. lua-luv) or to do both static > > and shared library builds (which we used to do for the folly stack). > > > > Also: if the CMakeLists.txt is not in the root of your project tarball, > > previously you can just do `%cmake actual-src-dir`. > > > > In F37's cmake 3.23, it seems that `cmake -S . ..` has the `-S .` trump > > the `..` when it comes to finding where CMakeLists.txt is, while > > previously `..` wins. > > > > I was working around it by simply `cd actual-src-dir` before `%cmake`, > > but it turns out simply passing an additional `-S` works, e.g.: > > > > ``` > > mkdir some-dir > > cd some-dir > > %cmake -S .. > > cd - > > ``` > > > > e.g. > > https://src.fedoraproject.org/rpms/lua-luv/pull-request/3 > > This makes me wonder. > > A lot of the things that are now reported as "broken" look like they > should already have been broken when we switched to out-of-tree builds > for CMake by default. > And a lot of the snippets look like things that I helped fix when that > change landed. > > So ... did anybody investigate what actually changed here? Was it a > behaviour change in cmake CLI argument handling, or have the actual > %cmake / %cmake_build etc. macros changed in a way that makes them no > longer backwards compatible? > Somebody did <https://bugzilla.redhat.com/show_bug.cgi?id=2057738#c2>. It's an intentional change in the upstream <https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7001>. -- Petr
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
