Re: nodejs-electron

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/27/22 02:32, Andreas Schneider wrote:
> On Sunday, 27 February 2022 01:37:08 CET Demi Marie Obenour wrote:
>> On 2/26/22 02:21, Andreas Schneider wrote:
>>> On Friday, 25 February 2022 14:02:11 CET Neal Gompa wrote:
>>>> I think this is probably one of those things that would be worth
>>>> forming a SIG on. An Electron SIG could help with Electron and all
>>>> Electron-based applications that come into Fedora.
>>>
>>> That would be fine by me. The most obvious application would be Element
>>> (Matrix). https://element.io/
>>
>> How do you plan to rebuild all of the NPM dependencies?  “Just use
>> what is in node_modules” runs into the problem that what is in
>> node_modules often isn’t actually source code.  Yes, I know that most
>> other packagers are likely using this approach, but it doesn’t meet
>> Fedora’s “everything must be built from source” requirement.
> 
> With signal I replaced the binary node modules with source ones. I also make 
> sure that there are no shared libraries or prebuild .node file around.
> 
> Most of the time a `node-gyp rebuild` is what you need to rebuild the 
> binaries.

Sadly, that isn’t sufficient.  node_modules/ will often contain
minified JavaScript, CSS, HTML, or some combination, and minified
files aren’t source code.  All of the minified files will need to be
regenerated from non-minified versions.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

Attachment: OpenPGP_0xB288B55FFF9C22C1.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux