Am 18.02.22 um 07:40 schrieb Yunmei LI:
We are looking to contribute Milvus to the fedora community to help more users with their AI applications.
I have already filled out a Milvus package review request in bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=2055596
Welcome to Fedora. I'm always glad if companies help maintaining their software
in Fedora (or other distros) :-)
One just a little hint for your package: I think you'll have to rework this a
bit. For example a Fedora package must not not depend on "epel-release" or
"centos-release-scl-rh" (this is also true for EPEL packages).
BuildRequiring "wget" seems strange. I guess the build process tries to download
something from the internet which is also forbidden in Fedora. You MUST include
all sources in your package or use packages already included in Fedora.
I see that you list OpenBLAS, cmake, go, boost and tbb in your sources. You
should remove all of these from your package and use only the packages already
included in Fedora. This might be a bit of work especially for somewhat complex
packages but it ensures that Fedora can provide some level of quality.
So again, thank you for your contribution. It's a good start and I'm pretty sure
that streamlining your software to match Fedora's processes will also help your
upstream quality.
Felix
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
