Re: GCC changes break "libscrypt" package in F36

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Denis Fateyev:

> Thank you, all variants work fine.
>
> Now I have another issue with "nfdump" package, probably for the same
> reason: a build flag interference.
>
> I use '-fPIC' in LDFLAGS to make "configure" happy:
> https://src.fedoraproject.org/rpms/nfdump/blob/rawhide/f/nfdump.spec#_49

-fPIC (or rather, -fPIE) must be in CFLAGS.  But the Fedora build flags
should be handling this correctly, via
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1.

The issue seems to be in the upstream makefiles.  Compilation completely
ignores CFLAGS:

gcc -DHAVE_CONFIG_H -I. -I..    -DPCAP -g -O3 -std=gnu11 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing -DNSEL -c -o nfcapd-nfcapd.o `test -f 'nfcapd.c' || echo './'`nfcapd.c

It is actually overriden by configure:

# Checks for programs.
CFLAGS="-g -O3"
AC_PROG_CC([clang gcc])
AX_CHECK_C11
CFLAGS="$CFLAGS -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -fno-strict-aliasing"

I suggest to delete that CFLAGS="-g -O3" line.

Thanks,
Florian
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux