On 1/28/22 14:18, Barry Scott wrote:
On 28 Jan 2022, at 12:28, Tomasz Torcz <tomek@xxxxxxxxxxxxxx> wrote:
On Fri, Jan 28, 2022 at 12:01:43PM +0000, Barry Scott wrote:
I just had to fix a number of my servers that use node exporter.
The service name has been changed. Why was this done and did no one
think about the impact on users?
This was done here:
https://src.fedoraproject.org/rpms/golang-github-prometheus-node-exporter/c/5ad49dd6ed767d44070866d996d844dec4b5f07b?branch=f35
as part of the fix for
https://bugzilla.redhat.com/show_bug.cgi?id=2039257
(golang-github-prometheus-node-exporter installs service unit in /etc)
Moving the unit is fine, but rename should not happen stable release.
At least some compat symlinks/Alias= should be provided.
In the worst case I had a server fail to reboot because I had
Requires=node_exporter.service in the default target.
It is unfortunate. It is also unfortunate no-one cared enough about
node-exporter to have it tested during 2 weeks time
(https://bodhi.fedoraproject.org/updates/FEDORA-2022-e52d3d8db2)
before it was submitted to stable.
I guess what is surprising me is that it's a breaking change and that was not
noticed in review or dev testing.
I have now updated golong-github-prometheus that has more breaking changes to handle.
The change in the way that .service file handles arguments is welcome.
But its not compatible with the previous .service files handling.
Barry
Hello,
I'm sorry, this is entirely my fault. I provided symlinks for the
binaries, but didn't think of the systemd unit files symlinks. The
services files were added or modified to take into account environment
files which were requested multiple times, and without which the package
were basically unusable. The binary were renamed to provide
commonalities with other distro.
Alert manager service was added, Node exporter and Prometheus were
fixed. There should not be any breaking change for Prometheus though,
the only thing added was the Environment file.
I will seek co-maintainers for these packages as I initially packaged
them to be used as dependency for other projects but I never intended to
be maintainer of the services, which are a bit out of my depth.
I will be pushing an update for node-exporter with a service symlink for
the old name.
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
