On Thursday, 6 January 2022 09.02.02 WET Mark E. Fuller wrote:
> Good day all,
>
> I have just submitted a review request
> (https://bugzilla.redhat.com/show_bug.cgi?id=2037645) for Cantera, a
> chemical kinetics, thermodynamics, and transport tool suite
> (https://cantera.org/,
> https://copr.fedorainfracloud.org/coprs/fuller/Cantera/).
>
> As this is my first package, I appreciate any constructive feedback and
> am looking for a sponsor.
> I am particularly interested in having the package ultimately available
> in EPEL as this would make installation on many HPC resources very simple.
>
> Regards,
> Fuller
Hi Mark,
I can review this an sponsor you.
Welcome to Fedora. :-)
On a first read you do not need to do a detailed listing in %files.
For example for cantera-common just writing
%{_datadir}/%{name}
will cover all the files that are inside that folder.
I will give a more detailed review in the bugzilla entry.
Best regards,
--
Jos�b�o
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
