updated the spec files for both gbuffy and libPropList. However, I wonder how to license it: currently they are under GPL and LGPL. Should these be GPLv2.1 and LGPLv2.1 since these are really old packages (even though I cleaned up gbuffy some). Btw, if I patch up a package that does not seem to be maintained, am I better off changing the name to avoid potential conflicts? I doubt that anyone would use this package, no one other than me appears to have felt the need and while I have used these for years, I would be happy to submit these to Fedora. Thanks! aarem@xxxxxxxxxxxxxxxxx On Thursday, November 11, 2021, 08:16:11 AM CST, David Cantrell <dcantrell@xxxxxxxxxx> wrote: Vitaly replied in this thread as well with other spec file changes you need to make to align with current packaging guidelines. For reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/ Other replies below... On Wed, Nov 10, 2021 at 09:48:24PM +0000, Globe Trotter via devel wrote: >My apologies, i spoke too soon. > >I updated Makefile.in to be: > >install: gbuffy > ./mkinstalldirs $(DESTDIR)$(bindir) > $(INSTALL) gbuffy $(DESTDIR)$(bindir) > >Here is my updated spec file: > >%define ver 0.2.8 >%define rel 1%{?dist} > >Summary: multiple mailbox buffy for GTK+ >Name: gbuffy >Version: %ver >Release: %rel >License: GPL The License value needs to match a license abbreviation from this page: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses For more information, see: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ You may combine multiple short license names using the "and" and "or" keywords. The packaging guidelines explain this in more detail. >Group: Applications/Communications >Source0: ~/C.libs/linux/%{name}-%{version}.tar.bz2 >Source1: http://www.fiction.net/blong/programs/gbuffy/gbuffy-%{ver}.tar.gz I don't understand what Source0 is here. Source0 should be the upstream source archive. Then you should add a Patch0 patch that makes the change to Makefile.in. The %autosetup macro in %prep will apply that patch after unpacking Source0. >BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-%(%{__id_u} -n) >URL: http://www.fiction.net/blong/programs/gbuffy >BuildRequires: libPropList > >%description >GBuffy is a GTK+ multiple mailbox "biff" program. It is conceptually >based on XBuffy by Bill Pemberton, but is a complete rewrite from >scratch. > >GBuffy will poll multiple mailboxes for new mail. It will list the >number of new messages in each mailbox you configure. It will also >highlight the mailboxes which have new mail. > >GBuffy is currently capable of watching MBOX, MMDF, Maildir and MH >Folders. This version also supports IMAP4rev1 and NNTP with XOVER >mailboxes. > >%prep >%setup -q > >%configure >%make_build > >%install >%make_install > >%files >%defattr(-,root,root,-) >%doc CHANGES README >%license LICENSE >%{_bindir}/%{name} > >%clean > > > > > >However, I still have some problems: > > >....... >+ cd gbuffy-0.2.8 >+ /usr/bin/make install DESTDIR=/home/rpmbuild/BUILDROOT/gbuffy-0.2.8-1.fc35.x86_64 'INSTALL=/usr/bin/install -p' >./mkinstalldirs /home/rpmbuild/BUILDROOT/gbuffy-0.2.8-1.fc35.x86_64/usr/bin >make: ./mkinstalldirs: Permission denied >make: *** [Makefile:50: install] Error 127 >error: Bad exit status from /var/tmp/rpm-tmp.QLLNwm (%install) > > >RPM build errors: > Bad exit status from /var/tmp/rpm-tmp.QLLNwm (%install) > > > >Is there something I did not do correctly? > >Many thanks! >_______________________________________________ >devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx >To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx >Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx >Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure -- David Cantrell <dcantrell@xxxxxxxxxx> Red Hat, Inc. | Boston, MA | EST5EDT _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
