On 12. 10. 21 10:35, Fabio Valentini wrote:
Hi everybody,
There seems to be some inconsistency with how our update workflow
currently works. When an update gets enough positive karma "pre-push"
(still in "pending → testing" state) so that it can be pushed to
stable, bodhi changes its state to ("pending → stable"), making it
skip the "updates-testing" repository entirely.
That isn't that big of a problem most of the time, since "fedora" /
"updates" and "updates-testing" repositories are composed daily, but
during freezes, this leads to the weird problem that possibly
important updates get stuck in a state where they are available from
*no repository at all*.
For example, this now happened to the flatpak 1.12.1 update:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-256d5ee9fe
It got +5 karma before the update was even available from the
updates-testing repository (presumably users tested the builds from
koji directly - I hope?), so it got pushed to "stable" by bodhi. But
now it's been sitting in "pending → stable" state for two days because
of the final freeze, making the update available from *no repository*,
while it's a pretty big update (1.11 → 1.12) and also contains
security fixes and bug fixes for Steam - maybe it should get a freeze
exception now, otherwise it will only become available as a 0day
update.
So, I wonder, should updates always be allowed to skip being in the
"updates-testing" repository entirely? There's probably good reasons
for it sometimes (for example, time-critical security updates, i.e.
firefox, kernel, etc.), but in the general case, not giving regular
"non-koji" update testers any time to test updates before they're
pushed to stable seems suboptimal.
Maybe updates should only be able to be pushed to stable by karma if
they are in the "testing" state, and need a manual "submit to stable"
button push if they're still "pending"? That should be both fairly
straightforward to implement in bodhi, and should allow for both the
"pending → stable fast-track, this is urgent" and the "lets wait and
let it sit in updates-testing for at least one day" scenarios.
What do you think?
This could also be solved by implementing the "pending -> stable" action to
always behave like "pending -> testing -> stable", rather than waiting an extra
day, no?
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
