Le 16/07/2021 à 10:39, Christopher Engelhard a écrit :
Hi all,
I finally found some time to unbundle all the 3rdparty PHP/composer
libraries from the nextcloud package.
The bad news is that due to their various dependency trees, I now have a
total of 24 new packages that need reviewing.
The good news is that I think quite a few of them will be generally
useful beyond just nextcloud.
They are all fairly small & simple PHP libraries, build without issues
and are basically identical in terms of packaging. If there are people
out there who'd like to try their hand at reviewing for the first time,
one of these might be a good place to start.
From a quick look, for all these packages
it seems useful to include upstream test suite
by pulling a git snapshot (common practice in PHP to workaround
the stupid .gitattributes usage)
Unbundling make sense when we can run CI (Koschei) and ensure
changes in the PHP stack (ex PHP 8.0 in F35 or 8.1 in F36) don't break
Also use range dependencies everywhere (even if a single version
packaged), this can change in the future.
I should be able to review (or help) on this set of reviews.
the PHP SIG mailing list (php-devel@...) is probably a better
place if you have any question about PHP specific packaging
Remi
Obviously, if you need something reviewed in return, I'd be happy to do
that.
Full list of links is below, but to make it easier for people
- I set up a dependency tree (
https://bugzilla.redhat.com/buglist.cgi?bug_id=1981857&bug_id_type=anddependson&format=tvp&list_id=12016550
) so you can pick a leaf.
- I made a copr repository (
https://copr.fedorainfracloud.org/coprs/lcts/nextcloud/packages/ ) that
has builds for all of these, including fedora-review/rpmlint logs (and a
big thank you to whoever made that last bit possible in Copr, that was
*extremely* useful). The repo also contains a few forks of existing
packages, ignore those :) .
Best,
Christopher
List of links:
https://bugzilla.redhat.com/show_bug.cgi?id=1982616
https://bugzilla.redhat.com/show_bug.cgi?id=1982618
https://bugzilla.redhat.com/show_bug.cgi?id=1982619
https://bugzilla.redhat.com/show_bug.cgi?id=1982621
https://bugzilla.redhat.com/show_bug.cgi?id=1982624
https://bugzilla.redhat.com/show_bug.cgi?id=1982627
https://bugzilla.redhat.com/show_bug.cgi?id=1982629
https://bugzilla.redhat.com/show_bug.cgi?id=1982630
https://bugzilla.redhat.com/show_bug.cgi?id=1982631
https://bugzilla.redhat.com/show_bug.cgi?id=1982632
https://bugzilla.redhat.com/show_bug.cgi?id=1982633
https://bugzilla.redhat.com/show_bug.cgi?id=1982635
https://bugzilla.redhat.com/show_bug.cgi?id=1982636
https://bugzilla.redhat.com/show_bug.cgi?id=1982637
https://bugzilla.redhat.com/show_bug.cgi?id=1982638
https://bugzilla.redhat.com/show_bug.cgi?id=1982639
https://bugzilla.redhat.com/show_bug.cgi?id=1982640
https://bugzilla.redhat.com/show_bug.cgi?id=1982643
https://bugzilla.redhat.com/show_bug.cgi?id=1982645
https://bugzilla.redhat.com/show_bug.cgi?id=1982646
https://bugzilla.redhat.com/show_bug.cgi?id=1982647
https://bugzilla.redhat.com/show_bug.cgi?id=1982648
https://bugzilla.redhat.com/show_bug.cgi?id=1982651
https://bugzilla.redhat.com/show_bug.cgi?id=1982652
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
