Petr Viktorin <pviktori@xxxxxxxxxx> writes: > On 14. 06. 21 17:52, Vitaly Zaitsev via devel wrote: >> On 14.06.2021 15:32, Ben Cotton wrote: >>> Running upstream tests is mandatory. >> >> What about tests that require network access? > > > Thanks for this and all the other concerns about mandatory tests! > I updated the proposal to mane them not mandatory, but require a smoke > test if they're not there. > I also removed the mention of Fedora CI: it was meant as an escape hatch > for tests that need network, but that's now unnecessary. > > Diff: > https://pagure.io/fork/pviktori/packaging-committee/c/ec9643873c989e0ff264128891665f6ad78f3e4a?branch=new-py-guidelines > History including other minor changes: > https://pagure.io/fork/pviktori/packaging-committee/commits/new-py-guidelines > > New wording: > > If a test suite exists upstream, > it *SHOULD* be run in the `+%check+` section. > If that is not possible with reasonable effort, > at least a basic smoke test (such as importing the packaged module) > *MUST* be run in `+%check+`. > > You *MAY* exclude specific failing tests. > You *MUST NOT* disable the entire testsuite > or ignore its result to solve a build failure. > > As an exception, > you *MAY* disable tests with an appropriate `+%if+` conditional > (e.g. http://rpm.org/user_doc/conditional_builds.html[bcond]) > when xref:index.adoc#bootstrapping[bootstrapping]. > > Most errors in Python happen at run-time, > so tests are extremely important to root out issues, > especially when mass rebuilds are required. > > Common reasons for skipping tests in `+%check+` include requiring > network access, > dependencies not packaged in Fedora, > and/or specialized hardware or resources. This is much better, thank you! And thanks Miro for the new macro! Cheers, Dan _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
