On 14. 06. 21 18:32, Vitaly Zaitsev via devel wrote:
On 14.06.2021 17:56, Miro Hrončok wrote:
Assuming that *all the tests* require network access, you should run them on
Fedora CI instead.
And if I don't want to patch tests in downstream or not interested in runing
tests at all?
For example my package wloc[1] has upstream tests, but they cannot run on
Fedora due to the lack of a test suite file and secret keys.
Another example is a package that requires special equipment to run tests.
I'm strongly against this part of proposal. The package maintainers should
decide whether they need tests or not.
There are two situations described here:
1) Running tests in %check is impossible, unreasonably hard or useless
In that case, I am inclined to agree running them should not be hard
requirement, the packagers should instead be required to document the reasoning
in the spec file.
2) Packager not interested in running tests at all
That is exactly the thing we need to avoid. Python packages without tests
always cause trouble when we measure impact of our changes. E.g. when we
continuously rebuild packages with the next Python release, pure Python
packages with incompatibilities but without %check always succeed the build,
but they break other packages.
Example Python 3.10 failures that only manifest themselves in the depending
packages because %check is non-existent or commented out:
https://bugzilla.redhat.com/show_bug.cgi?id=1968737
https://bugzilla.redhat.com/show_bug.cgi?id=1969311
https://bugzilla.redhat.com/show_bug.cgi?id=1919789
https://bugzilla.redhat.com/show_bug.cgi?id=1926112
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
