Il 04/06/21 21:46, Fabio Valentini ha scritto: > > Well, there are two different cases here, aren't there? > > For side tags created for rawhide, they are - in my experience - > automatically deleted by bodhi once the update goes to stable, shortly > after it is created. > > For those created for stable releases, I think it makes sense to keep > them around until the update is pushed to stable, too - otherwise you > won't be able to edit the update at all. It looks like the bug that > bodhi didn't delete those side tags after the update is pushed to > stable has been fixed? At least, all my > side-tags-for-stable-release-updates-that-are-now-stable are gone. > In the past it was discussed and decided to not have Bodhi delete the side-tag itself, but to rely on the koji auto purge that automatically delete side-tags that are empty. This has always worked for Rawhide side-tag updates, but there was a bug, fixed in Bodhi 5.7.0 [1], for which when Bodhi pushed a current release side-tag update the side-tag was not removed from the builds, so the side-tag was never emptied. There is still a case not covered: when a side-tag build is performed and later another updated build of the same package is created in the side-tag, the older build is never removed from the side-tag. In this case, when Bodhi pushes the update to stable, the older build remains tagged in the side-tag, thus Koji will never delete it. I suppose we can safely delete the side-tag, provided that we only delete it when we're sure the update has been pushed to stable. During the testing phase, the side-tag should be left available to eventually update some builds within it. Maybe, we can add a celery task to Bodhi to defer the side-tag deletion, I don't think it's strictly necessary to delete it in real time. Has anyone got any reason for having the side-tag live after the update goes to stable? Mattia [1] https://github.com/fedora-infra/bodhi/pull/4173 _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
