Re: F35 Change: Replace the Anaconda product configuration files with profiles (Self-Contained Change proposal)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 04, 2021 at 03:37:57PM -0400, Ben Cotton wrote:
> * The detection based on the <code>os-release</code> files will no
> longer work because of
> [https://fedoraproject.org/wiki/Changes/Fedora_Linux_in_os-release a
> Fedora 35 change].

I'm not arguing against the proposed change here, but this shouldn't be a
reason. In fact, I'm generally _for_ the change. But:

The detection¹ seems to be looking at human-readable NAME and designed for
machine parsing VERSION_ID instead of both machine-parseable ID and
VERSION_ID as it should be.

Unless the plan is to just remove this code, that was always a bug and
should be fixed regardless of this feature.





[1] https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/modules/storage/devicetree/root.py,
right?

-- 
Matthew Miller
<mattdm@xxxxxxxxxxxxxxxxx>
Fedora Project Leader
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux