Re: New RPM submission

[Joan Moreau via devel <devel@xxxxxxxxxxxxxxxxxxxxxxx>]

fixed

On April 25, 2021 16:27:57 Dennis Gilmore <dennis@xxxxxxxx> wrote:

some of the changes have just been committed already, or an equivalent.

The value you have for the license is incorrect

https://fedoraproject.org/wiki/Licensing:Main lists the correct values

-License:        LGPL-2.1

+License:        LGPLv2

There is no need to explicitly Require xapian-core-libs as rpm

requires the correct shared library provided automatically.

-Requires:       xapian-core, xapian-core-libs, dovecot

+Requires:       xapian-core, dovecot

the description needs to be broken down into shorter lines.  I would

probably expand somewhere in the description that FTS stands for Full

Text Search

 %description

-This project intends to provide a straightforward, simple and

maintenance free, way to configure FTS plugin for Dovecot, leveraging

the efforts by the Xapian.org team.

-

-This effort came after Dovecot team decided to deprecate "fts_squat"

included in the dovecot core, and due to the complexity of the Solr

plugin capabilitles, un-needed for most users.

+This project intends to provide a straightforward, simple and maintenance

+free, way to configure FTS plugin for Dovecot, leveraging the efforts by

+the Xapian.org team.

+

+This effort came after Dovecot team decided to deprecate "fts_squat"

+included in the dovecot core, and due to the complexity of the Solr plugin

+capabilitles, un-needed for most users.

Dennis

On Sun, Apr 25, 2021 at 10:04 AM Joan Moreau <jom@xxxxxxxxxx> wrote:

you probably sent the same srpm

No, it is a new one , re-generated

just fine, I did make a few changes to the spec file. with a correct changelag entry it should pass review

What changes are you suggesting ?

_______________________________________________

devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx

To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx

Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/

List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines

List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx

Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure