On 03/02/21 12:24 -0000, Martin Gansser wrote:
you mean, this part of the patch can be removed ?
@@ -336,14 +331,14 @@
inline char_traits<cxxtools::Char>::char_type*
char_traits<cxxtools::Char>::move(char_type* s1, const char_type* s2, int_type
n)
{
- return (cxxtools::Char*)std::memmove(s1, s2, n * sizeof(cxxtools::Char));
+ return
static_cast<cxxtools::Char*>(std::memmove(static_cast<void*>(s1),
static_cast<const void*>(s2), n * sizeof(cxxtools::Char)));
}
inline char_traits<cxxtools::Char>::char_type*
char_traits<cxxtools::Char>::copy(char_type* s1, const char_type* s2, size_t
n)
{
- return (cxxtools::Char*)std::memcpy(s1, s2, n * sizeof(cxxtools::Char));
+ return
static_cast<cxxtools::Char*>(std::memcpy(static_cast<void*>(s1),
static_cast<const void*>(s2), n * sizeof(cxxtools::Char)));
}
Yes, I think so.
With the operator= removed (or defined as default) the type is
trivially copyable, so it's OK to use memmove and memcpy on it. So you
shouldn't get any warnings about doing that.
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
