On Mon, Jan 25, 2021 at 10:35:44AM -0500, Stephen Gallagher wrote: > On Mon, Jan 25, 2021 at 10:31 AM Miro Hrončok <mhroncok@xxxxxxxxxx> wrote: > > > > On 25. 01. 21 16:19, Stephen Gallagher wrote: > > > I'm fully in favor of this and I'd really like to see us add some > > > degree of CI gating to support it. > > > > Note that unfortunately CI gating happens too late. It has no capability to > > block commits that fail to build, because it only tests successful builds and > > because it only tests already pushed changes. CI on Pull Requests can solve > > this, but many packagers seem to be very much agianst the idea of sending PRs to > > packages they maintain themselves :( > > > > There are still ways around this; we could disallow direct pushes to > release branches. Please don't do this, the PR workflow is annoyingly complex and next to impossible to automate, compared to doing a simple git push. Rich. > Yes, there are always going to be people who reject any new approach > we might take, but we should carefully consider whether "some/many > packagers are mildly annoyed" exceeds the potential gains inherent in > fewer broken builds and composes. > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
