On Tue, Jan 19, 2021 at 10:43 AM Robbie Harwood <rharwood@xxxxxxxxxx> wrote:
>
> Ben Cotton <bcotton@xxxxxxxxxx> writes:
>
> > A simple `sed` can be applied in `%prep` as a temporary (or even
> > permanent) downstream solution.
> >
> > In most cases, performing the following replacement should be enough:
> >
> > s/^(\s*)import mock/\1from unittest import mock/
> > s/^(\s*)from mock import /\1from unittest.mock import /
> >
> > * Other developers: No action needed. Don't add new dependencies on
> > {{package|python3-mock}}. If interested, migrate existing packages to
> > `unittest.mock` (feel free to ask for help)
>
> Those three snippets together suggest to me that the way this migration
> will be performed is that you're going to ProvenPackager in a couple
> lines of sed to all (affected) specfiles. I hope I have misunderstood,
> because that has no mechanism to get the changes back into upstreams.
> Could you clarify what you intend to do?
>
> > == Dependencies ==
> > N/A (not a System Wide Change)
>
> You're proposing changing many packages, so I don't think this qualifies
> as a self-contained change. The actual removal would be, but not
> dependency patching.
>
> Speaking of dependencies, though, I'm not seeing a list of packages that
> are affected. Could you provide one?
>
The way this change is worded, nothing is actually *happening* other
than a policy change that new packages cannot use this dependency
without a FESCo exception (standard deprecated package policy). If
*existing* packages want to change, this Change document describes the
expected effort required to remove it as a dependency to use the
built-in one in Python.
Thus, it makes sense as a Self-Contained Change.
--
真実はいつも一つ！/ Always, there's only one truth!
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
