On Thu, 2021-01-07 at 20:58 +0000, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Jan 07, 2021 at 09:25:44AM -0800, Adam Williamson wrote: > > Hey folks! > > > > So here's an idea I was thinking about over the RH shutdown: I propose > > we gate stable release critical path updates on the openQA tests. > > +1 > > > The result of this would be that critpath updates could not go stable > > if any of the openQA tests failed, unless a waiver was issued. I think > > this should be viable and not cause any major issues. > > Just to confirm: the packager who issues the update is allowed to > create the waiver? At least that, yeah. I think it's the same permission as editing an update - if you can edit the update, you can issue a waiver for it. That's a whole *other* can of worms I'm going to get into later ;) > When I initially read the proposal, I was immediately worried about > false positives. But the fp rate seems low, so it looks alright to > start gating. Right, we basically aim to resolve *all* false failures one way or another, rapidly, and I think we've got a fairly good record there. > > There's the related issue that the critpath list is outdated: > https://pagure.io/releng/issue/8948. > It's not really required to have it up-to-date, but if we don't we'll > be gating on some packages we shouldn't gate on, and not gating on > some we should. Yup. It's not as bad as I thought, though - best as I can tell there's actually only one unapplied change, plus the PR I have open. Of course, it really should be re-generated regularly to take changes in dependencies into account. -- Adam Williamson Fedora QA IRC: adamw | Twitter: adamw_ha https://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx