On Thu, Dec 3, 2020 at 3:39 PM Fabio Valentini <decathorpe@xxxxxxxxx> wrote: > I still think a lot of those are "false positives". > CMake has a hard Requires on make, so if I BuildRequires cmake, adding > "BuildRequires: make" is just redundant. > https://src.fedoraproject.org/rpms/cmake/blob/master/f/cmake.spec#_185 I think this was discussed previously, but while cmake may have a requires on make today, cmake can now use ninja rather than make in at least some cases, so one should certainly not presume cmake will always require make. If the build requires make, it should call it out explicitly. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
