Re: Java reviews (with swaps)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 25, 2020 at 7:39 PM Jerry James <loganjerry@xxxxxxxxx> wrote:
>
> Sorry for the late reply.
>
> On Thu, Nov 19, 2020 at 2:25 AM Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> wrote:
> > This warning is relevant for upstream projects, but you can safely
> > ignore it when building RPM packages with XMvn - it always uses
> > packaged versions of Maven plugins, ignoring versions configured in
> > POM.
>
> That's good to know.  Thank you for the information.
>
> > IMHO (1), (3), (2), in that order of preference.
> > (3) is the most elegant solution, but requires maintaining one more
> > package than (1), which also works. (2) doesn't make much sense - it
> > would only silence the warning at the cost of cluttering the spec
> > file, making it harder to maintain.
>
> I have gone with (1) as you suggested.
>
> > It's hard to say without looking at the POM structure. I can check if
> > you give me a reference to the code (upstream, SRPM etc).
>
> Fabio figured out that it's because all of the module references are
> inside profiles.
>
> I'm still willing to swap reviews for whoever has time for this.
> Fabio suggested a slight name change, which I adopted:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1898312 (jakarta-json)

I'll look at the package, but I cannot promise to get the review done
before tomorrow. :)

Fabio
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux