review-stats bot spamming "failed to clear NEEDINFO" messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Recently we've had a new automation introduced, which seeks out stalled
review requests and tries to prod them to move forward.

One of the ways it does this is by looking at reviews which have the
NEEDINFO flag set and, if the ticket reviewer failed to reply
for a long time, it resets the ticket status and assignee.
This allows someone else to take over the review.

However, as witnessed here [1], there is a bug in the automation,
causing it to spam a ticket endlessly. Guessing by that thread,
the cause of this seems to be:
a) failing to check if the NEEDINFO flag is set for the *submitter*,
   instead of a reviewer
b) failing to clear the NEEDINFO flag for the submitter

Since the NEEDINFO flag is not cleared, the next time the automation
stumbles across the ticket, all the conditions required for it
to take action and post a message are still there.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1723013
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux