On Wed, 2020-08-05 at 07:59 -0400, Neal Gompa wrote:
> On Wed, Aug 5, 2020 at 7:53 AM Lukáš Hrázký <lhrazky@xxxxxxxxxx> wrote:
> > Hi Neal, all,
> >
> > On Tue, 2020-08-04 at 07:42 -0400, Neal Gompa wrote:
> > > ...
> >
> > What if I build for multiple platforms at the same time? E.g. in dnf we
> > have:
> >
> > %build
> > %if %{with python2}
> > pushd build-py2
> > %cmake -DPYTHON_DESIRED:FILEPATH=%{__python2} -DDNF_VERSION=%{version}
> > %cmake_build
> > make doc-man
> > popd
> > %endif
> >
> > %if %{with python3}
> > pushd build-py3
> > %cmake -DPYTHON_DESIRED:FILEPATH=%{__python3} -DDNF_VERSION=%{version}
> > %cmake_build
> > make doc-man
> > popd
> > %endif
> >
> >
> > Do the new macros handle this case as well or do I need to stick to the
> > old way (with defining the variable)?
> >
>
> It appears Igor already did the conversion for you[1][2], but you
> could also elect to go the other way as you considered.
>
> However, you may want to go ahead and start simplifying that spec
> because we're not building Python 2 support anywhere. Even RHEL 7
> isn't getting updated versions of DNF anytime soon.
>
> [1]: https://src.fedoraproject.org/rpms/dnf/c/a8a0affb4c4fd1022f18b203d578e2230cce30df?branch=master
> [2]: https://src.fedoraproject.org/rpms/dnf/c/61ec663be5c477cea68afb60279773661e186c52?branch=master
Thanks, Neal. We'll keep the conditional python 2/3 builds in for a bit
longer, just in case we ever need to build for RHEL 7.
In the linked fix it's setting a global _vpath_builddir, which looks a
bit like a workaround for the %cmake macros not supporting multiple
build dirs, is that right?
Cheers,
Lukas
> --
> 真実はいつも一つ！/ Always, there's only one truth!
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
