On Tuesday, 4 August 2020 12.42.30 WEST Neal Gompa wrote:
> Then you should do the following:
>
> %undefine __cmake_in_source_build
>
> %cmake
> %cmake_build
> %cmake_install
Would not it be more clean to place the %undefine line inside guards?
%if (0%{?rhel} || (0%{?fedora} && 0%{?fedora} < 33))
%undefine __cmake_in_source_build
%endif
I am asking this because I always forgot when was a given functionality
introduced or it is no more required.
A simple example is "rm -rf $RPM_BUILD_ROOT" that I know that it is not
necessary in Fedora anymore but it is very easy to know in which epel version
it is necessary ( <= 6 I think).
Does that solution makes sense or am I over-engineering this?
Regards,
--
José Abílio
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
