On Sun, Jul 12, 2020 at 12:15 PM Andy Mender <andymenderunix@xxxxxxxxx> wrote:
On Sat, 11 Jul 2020 at 21:47, Robert-André Mauchin <zebob.m@xxxxxxxxx> wrote:%build
%cmake \
-B build \
-DUSE_BOOST_WAVE=ON \
-DUSE_PARTIO=OFF \
-DCMAKE_CXX_STANDARD=14 \
-DLLVM_STATIC=0 \
-DENABLERTTI=ON \
-DSTOP_ON_WARNING=OFF \
-DOSL_BUILD_MATERIALX:BOOL=ON \
-DCMAKE_INSTALL_DOCDIR:PATH=%{_docdir}/%{name} \
-DOSL_SHADER_INSTALL_DIR:PATH=%{_datadir}/%{name}/shaders/
I'm not familiar with openshadinglanguage, but I don't think enforcing C++14 like this is a good idea. Conformance to a particular C++ standard should be left to the project. I am actually contributing to a project which uses C++11 and builds properly with llvm/clang 10. If it's used as a workaround, I would add a comment to the spec file + a link to an issue ticket on GitHub if one exists (or create such a ticket if that's not the case) :).
This is what the upstream project explicitly says to do when using LLVM10: https://github.com/imageworks/OpenShadingLanguage/blob/master/src/cmake/externalpackages.cmake#L248. As such, it should be expected and no upstream bug is needed.
-Ian
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
