Re: Please BuildRequire python3-setuptools explicitly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 23, 2020 at 06:28:00PM -0000, Miro Hrončok wrote:
> > On Tue, Jun 23, 2020 at 06:26:23PM +0200, Tomas Hrnciar wrote:
> > 
> > This package depends on python3-devel.  However the last build.log:
> > 
> >  
> > https://kojipkgs.fedoraproject.org//packages/qemu/5.0.0/2.fc33/data/logs/...
> > 
> > does not contain the substring /setupto/ anywhere.  Nor does the
> > upstream git repo.  How do we know it is required?
> 
> $ fedpkg prep
> $ rg setuptools qemu-5.0.0
> qemu-5.0.0/capstone/bindings/python/setup.py
> 10:from setuptools import setup
> 14:from setuptools.command.bdist_egg import bdist_egg
> 176:    from setuptools.command.develop import develop
> 
> Is this file used during the build? If not, it's a false hit.

Oh I see, it's a git submodule which is why my "git grep" on the
upstream repo didn't catch it.

However we actually use ‘configure --disable-capstone’, because we
remove the bundled library and use the Fedora-built capstone instead.
So I don't believe setuptools is needed.  I guess we'll find out if it
breaks down the road.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux