On 6/20/20 9:14 PM, Zbigniew Jędrzejewski-Szmek wrote:
On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote:
The %make_build macro enables parallel make builds using the -j option. In
case a package does not build correctly with parallel make, then parallel
make will be disabled for that package by redefining the %_smp_mflags macro
like this:
%global _smp_mflags -j1
Please use this instead:
%global _smp_ncpus_max 1
That allows the same thing to be abstracted to whatever make system
might be running underneath, some of which have different semantics wrt
-j arguments or use a different switch altogether etc.
That is rather unwiely, in particular because it's quite common for
just *some* make invocations to fail in parallel mode. (E.g. the main
build works, but doc build fails, or install, etc.)
Why not specify the override for the individual invocation:
%make_build -j1
%make_install -j1
%make_build -C docs -j1
This kind of thing gets easily lost in the noise, whereas a macro
definition is easy to spot and grep for.
- Panu -
Zbyszek
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
