On 09/06/2020 08:54, Kalev Lember wrote:
The build failed with:
/builddir/build/BUILD/ispc-1.13.0/src/bitcode_lib.cpp: In member function 'void BitcodeLib::print() const':
/builddir/build/BUILD/ispc-1.13.0/src/bitcode_lib.cpp:61:17: error: variable 'type' set but not used [-Werror=unused-but-set-variable]
61 | const char *type = nullptr;
| ^~~~
cc1plus: all warnings being treated as errors
This means that the compiler found a tiny warning (unused variable) but
treated it as an error because -Werror was set during the build.
What I would suggest doing is looking into how to disable -Werror (it
could be a configure flag) or perhaps just patch it out for Fedora
builds. -Werror makes a lot of sense for upstream where they want to
make sure their build is warning free, but not for a distribution such
as Fedora where we introduce new changes all the time (each compiler
adds new, different warnings) and it's completely impractical to have
-Werror turned on for our builds.
It looks to be hard coded upstream:
https://github.com/ispc/ispc/blob/master/CMakeLists.txt#L355
so I suggest just adding to the spec:
sed -i 's| -Werror | |g' CMakeLists.txt
as is already being done for some other flags.
Tom
--
Tom Hughes (tom@xxxxxxxxxx)
http://compton.nu/
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
