On Tue, 14 Apr 2020 at 00:15, Ondrej Nosek <onosek@xxxxxxxxxx> wrote: > > TLDR: Is $SUBJ function reasonable to implement in fedpkg? > > Hi, > > some time ago, fedpkg issue tracker got a request [1] for method, that allows direct builds. That means without sending srpms via "--srpm" argument. Currently, user's changes can be built: > > fedpkg scratch-build --srpm > > This way, fedpkg sends srpm file to koji. Without "--srpm", fedpkg sends just (git) hash id to koji. But fedpkg needs modification to send a right hash id for user changes. Additionally, koji doesn't allow building hash ids from forked repos. > The question to the community. Is reasonable to implement this way of building scratches? --srpm argument would still work as previously. Hello Ondrej, I think it is reasonable given that koji implements a new config option named something like: `allowed_scms_for_scratch` to explicitly name uris allowed for scratch builds. It makes it clear what scms are allowed for scratch builds and what are allowed for normal builds. clime > > There is a suggested PR for this here: [2]. It is not completed yet. > > Risks: > * approach could confuse users. Users are used to work with fedpkg differently. > * koji would have to allow these builds > * more code complexity; currently there is a way how to reach your result even without this function > > Thanks > Ondrej > > [1] https://pagure.io/fedpkg/issue/282 > [2] https://pagure.io/fedpkg/pull-request/390 > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
