On Mon, Mar 09, 2020 at 03:19:03PM +0100, Dan Horák wrote:
On Mon, 9 Mar 2020 10:12:26 -0400
David Cantrell <dcantrell@xxxxxxxxxx> wrote:
On Sun, Mar 08, 2020 at 10:59:19AM +0000, Zbigniew Jędrzejewski-Szmek
wrote:
>Hi,
>
>for a recent systemd build, the automated tests results showed
>failure [1], and one of the failing tests was
>fedora-ci.koji-build.rpminspect.static-analysis.
>
>When I click on the label, I get redirected to [2], which is a long
>list of stuff like "print message" and "shell script" and "ci
>notifier". They are all green, and after clicking on one of them to
>unroll it, the display jumps, so it took me a while to figure out
>that the interesting item is one of the "shell scripts". Dunno, when
>doing this a second time I wouldn't be confused so much, but a
>slightly less elaborate UI which makes the failing test result more
>prominent would be nice.
>
>[1] https://bodhi.fedoraproject.org/updates/FEDORA-2020-b49f1d9b82
>[2]
>http://fedora-build-checks.apps.ci.centos.org/blue/organizations/jenkins/fedora-rpminspect/detail/fedora-rpminspect/3219/pipeline/
>
>Anyhoo, getting to the failing test:
>there's a long list of two repeated items:
>
>[2020-03-06T13:45:51.450Z] rpminspect output for humans - see
>rpminspect.json for full details [2020-03-06T13:45:51.450Z] Overall
>Result: NOT PASSED [2020-03-06T13:45:51.450Z] NOT PASSED items:
>
>[2020-03-06T13:45:51.450Z] header-metadata:
>[2020-03-06T13:45:51.450Z] message: Package Build Host "unused"
>is not within an expected build host subdomain in
>systemd-tests-debuginfo-245-1.fc33.s390x
>[2020-03-06T13:45:51.450Z] remedy: Make sure the SRPM is built
>on a host within the expected subdomain.
>
>Seems fully bogus? "unused" might be a placeholder value, but even
>if it wasn't, we have a dedicated server farm to build things.
>As a packager, I don't have any control over the hostname of the
>builder and I shouldn't ever need to care.
I'm not sure if this is still a policy requirement, but as I have
worked my way through rpminspect's ancestor I came across this
check. It looks at the build host in the RPM headers and looks to
see if the hostname ends with a particular string. For Fedora
packages, that would be ".fedoraproject.org" and for RHEL packages,
that would be ".redhat.com".
The substring that it looks for can be configured in
/etc/rpminspect/rpminspect.conf. The setting is
"buildhost_subdomain" and probably looks like this on Fedora:
buildhost_subdomain = ".fedoraproject.org .bos.redhat.com"
The .bos.redhat.com part is there for s390x builds.
If you don't want to run this test, you can comment out
buildhost_subdomain in rpminspect.conf. Given the string is "unused"
in your output, I'm not sure if we have changed policy to just stop
writing that data out (or if rpm did...).
as I suspect this is an infra configuration problem with the
s390x builders, I have just opened
https://pagure.io/fedora-infrastructure/issue/8731
There is really something wrong with the BuildHost tag values.
So rpminspect caught something. Nice. :)
--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat, Inc. | Boston, MA | EST5EDT
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
