Re: deduplicating noarch subpackages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/12/20 8:29 AM, Adam Jackson wrote:
> On Tue, 2020-02-11 at 16:21 -0800, Josh Stone wrote:
> 
>> Another alternative is to try to remove the host information from the
>> metadata hash, which I've already started upstream[3], but I'm not sure
>> alleviate their concerns about caching and such.
>>
>> [3] https://github.com/rust-lang/cargo/pull/7873
>>
>> Worst case, I could just build them as arch'ed subpackages, specific to
>> the host which compiled them.
> 
> I'd lean in favor of removing at least the architecture part of the
> host triple from the hash. koji is still going to build those noarch
> packages on every architecture and compare them, so if you do remove
> the arch from the hash and they all compare equal, it can't have
> mattered which arch you built it from.

FWIW, I don't think Koji actually cares if the files are *identical*, as
long as the file list is the same. The rpmdiff call says:

        # ignore differences in file size, md5sum, and mtime
        # (files may have been generated at build time and contain
        #  embedded dates or other insignificant differences)
        d = koji.rpmdiff.Rpmdiff(joinpath(basepath, first_rpm),
            joinpath(basepath, other_rpm), ignore='S5TN')
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux