On Tue, Jan 21, 2020 at 1:35 PM Miro Hrončok <mhroncok@xxxxxxxxxx> wrote: > > Hello, Hi Miro, > we try to rebuild all Python packages against Python 3.9 and report the > failures. I've seen several similar failures in a row now that can be reproduced > in Fedora rawhide with the new gcc version. > > ld errors on multiple definitions of ..., for example: I've seen this issue pop up in some other packages, as well. My elementary-files package is affected, and I think it broke rubygem-ffi, too (which is blocking the ruby 2.7 rebuild, breaking a lot of ruby packages; though I can't access the build log for the failed rubygem-ffi build, due to a koji bug relating to side tags). Fabio > ld: > tests/bp_account.o:/builddir/build/BUILD/kernel-5.4.fc32/linux-5.4/tools/perf/tests/bp_account.c:22: > multiple definition of `the_var'; > tests/bp_signal.o:/builddir/build/BUILD/kernel-5.4.fc32/linux-5.4/tools/perf/tests/bp_signal.c:38: > first defined here > > This is a known thing in gcc 10: > > https://gcc.gnu.org/gcc-10/porting_to.html#common > > "Default to -fno-common > > A common mistake in C is omitting extern when declaring a global variable in a > header file. If the header is included by several files it results in multiple > definitions of the same variable. In previous GCC versions this error is > ignored. GCC 10 defaults to -fno-common, which means a linker error will now be > reported. To fix this, use extern in header files when declaring global > variables, and ensure each global is defined in exactly one C file. As a > workaround, legacy C code can be compiled with -fcommon. > > > int x; // tentative definition - avoid in header files > > extern int y; // correct declaration in a header file" > > > Here are some packages affected: > > > nemo-extensions > https://bugzilla.redhat.com/show_bug.cgi?id=1793470 > > thunarx-python > https://src.fedoraproject.org/rpms/thunarx-python/pull-request/1 > > kernel-tools > https://bugzilla.redhat.com/show_bug.cgi?id=1793473 > > > https://bugzilla.redhat.com/show_bug.cgi?id=1793424 > > gnome-abrt, glusterfs... > > > > Before I go and file dozens of bugzillas, do we want to handle this somehow better? > > -- > Miro Hrončok > -- > Phone: +420777974800 > IRC: mhroncok > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
