On Fri, 2020-01-10 at 08:03 +0100, Igor Gnatenko wrote: > No, that's not true. Anybody can tag their builds into a > f31-updates-candidate and such tags. I have to test it to see, ATM without stupid tests on production which I don't want to do, I can't test it. But if so, is less problematic . And in case of cancel one koji build but in the end just canceled the tag-build task ? Can we change the build from completed to failed ? I think not . Which means we can't built it again . Thinking loud, maybe the best of two worlds was koji mark build as failed but let resubmit the failed task and completed the build successfully . koji builds marked as completed but with fails tasks should be avoided, in my opinion , this case is not the only case that I'm thinking, I had similar problems in past . Thanks, > On Fri, Jan 10, 2020 at 4:03 AM Sérgio Basto <sergio@xxxxxxxxxx> > wrote: > > On Thu, 2020-01-09 at 09:17 +0100, Pierre-Yves Chibon wrote: > > > On Wed, Jan 08, 2020 at 10:32:42PM +0000, Sérgio Basto wrote: > > > > Hi, a little "by the way" , I think if koji fails to tag the > > > > build > > > > or > > > > anything else, the final result should be failed, to avoid > > > > inconsistencies. I opened an issue on koji [1] > > > > [1] > > > > https://pagure.io/koji/issue/1895 > > > > > > We'll see how it goes, however I am not enthusiastic about this > > > idea, > > > tagging a > > > build is a much shorter task than doing a full rebuild (think > > > LibreOffice or > > > something along those lines that takes 1h+ to build, the tagging > > > operation is > > > done in seconds). > > > I agree that build without tags are harder to debug, especially > > > if > > > you do not > > > know what to look for, but once you do and know how to fix, it's > > > a > > > much quicker > > > solution. > > > > Let me disagree with your arguments, in two points . > > > > - Save time, if we count the times losses and gains, I think we > > didn't > > save time. quite the opposite, because we have to review all > > builds, > > search for all inconsistencies, etc ... > > > > - Second point is the fix, the fix just can be done by one admin , > > i.e. > > an regular user without admin permissions can't tag the build and > > the > > workaround is build another release which is an ugly solution. > > > > Best regards, > > -- > > Sérgio M. B. > > _______________________________________________ > > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > > Fedora Code of Conduct: > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > > List Guidelines: > > https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: > > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx -- Sérgio M. B. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
