Hello,
On Fri, Dec 27, 2019 at 7:44 AM Globe Trotter via devel
<devel@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> However, I have a problem: the issue is that Source0 does not have the latest tar.bz2 while Source1 does not call it 1.0.0 though the release notes say so (there).
You should have just one SourceX tag for each tarball. Since all three
of your links essentially point to the same thing and the actual
upstream is on github, keep only the URL to the source package you are
using. In your case, you are using a git snapshot, so you should be
following the relevant guidelines[0, 1], which if I'm interpreting
correctly, should result in something like this:
%global commit 875325103234b4a3ed96a4a5167ff78c291edbff
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate 20191215
Name: pdf-stapler
Version: 1.0.0
Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}
Summary: Tool for manipulating PDF documents from the command line
License: BSD
URL: https://github.com/hellerbarde/stapler
Source0: https://github.com/hellerbarde/stapler/archive/%{commit}/%{name}-%{shortcommit}.tar.gz
(The actual source URL is this one:
https://github.com/hellerbarde/stapler/archive/875325103234b4a3ed96a4a5167ff78c291edbff/stapler-87532510.tar.gz
)
> So, I put in a Source2: which contains the local tar.bz2 that I have. There is no error in the compilation but fedpkg build seems to have an error that I do not seem to get:
>
> aarem's pdf-stapler-1.0.0-1.fc32 failed to build
> http://koji.fedoraproject.org/koji/buildinfo?buildID=1424956
It appears that the tests defined in the %check section download some
files over the internet and since koji does not allow internet access,
the test suite is failing. I did not check what is defined in the test
suite, but your options are to disable checks, include the test files
as separate sources or package them as new packages (going through the
review process), depending on their nature.
0. https://fedoraproject.org/wiki/Packaging:SourceURL
1. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
