On Fri, Dec 20, 2019 at 1:37 PM Jan Kratochvil <jan.kratochvil@xxxxxxxxxx> wrote: > > On Thu, 19 Dec 2019 22:42:02 +0100, Ben Cotton wrote: > > == Summary == > > Enabling fstrim.timer will cause fstrim.service to execute weekly, > > which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet` > > This is AFAIK not enough for LUKS drives, will it be supported for LUKS? Good question. This change [1] happened in Fedora 27. But because there's neither `discard` mount option, nor fstrim.timer enabled by default, that feature doesn't really do anything for most users. This feature proposal would build on that previous approval. If your LUKS drives are listed in fstab, they will have fstrim issued and it will pass down to the physical drive. I've updated the proposal how to modify fstrim.service unit to specify --all instead of --fstab, so all mounted devices have fstrim passed to them. [1] https://fedoraproject.org/wiki/Changes/EnableTrimOnDmCrypt -- Chris Murphy _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx