On Thu, Dec 19, 2019 at 8:40 PM Stuart D. Gathman <stuart@xxxxxxxxxxx> wrote: > > On Thu, 19 Dec 2019, Ben Cotton wrote: > > > https://fedoraproject.org/wiki/Changes/EnableFSTrimTimer > > > > == Summary == > > Enabling fstrim.timer will cause fstrim.service to execute weekly, > > which in turn executes `/usr/sbin/fstrim --fstab --verbose --quiet` > > > == How To Test == > > The low level function of systemd timers, fstrim.service, and fstrim > > command are well understood and tested already, all Fedora needs to > > test is that the timer is enabled following clean installation and > > upgrades: > > After the initial change of defaults, the fstrim.timer SHOULD NOT be > re-enabled on subsequent updates if a user (who like me prefers choosing > when to run fstrim on which filesystem) has disabled it. It's an interesting question. I'm not sure what the upgrade policy is for vendor presets. Because there's a general expectation of getting new features upon upgrade, without having to do a clean install, I think this one should be enabled on upgrades. But I'm not sure how to make sure F32>F33 upgrade does not reenable if the user has disabled it; but still enable it with F31>F33 since Fedora supports upgrades that skip one release. So yeah, I need to figure that out. As for customizations to fstrim.timer, the original from /usr should be copied and put into /etc, and customized. That shouldn't be replaced on an upgrade. The fstrim.timer in /usr of course could be replaced, like anything else. Same for fstrim.service in case you want to trim all mounted file systems instead of just fstab. -- Chris Murphy _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
