On Tue, Dec 3, 2019 at 7:08 PM Leigh Scott <leigh123linux@xxxxxxxxx> wrote: > > Hi, > > Can someone check these specfiles before I submit review requests please? > I have zero experience with packaging rubygem packaes. > > https://leigh123linux.fedorapeople.org/pub/SPECS/rubygem-hrx.spec > https://leigh123linux.fedorapeople.org/pub/SPECS/rubygem-linked-list.spec > > Best regards > Leigh Hi Leigh, Those two packages look like two pretty standard rubygem packages (probably coming from manually sanitized gem2rpm output?). The only strange things I see at first glance are the two binaries that are shipped with linked-list: "setup" and "console" (and usually, ruby scripts are copied to _bindir, not moved). Are these binaries / scripts really necessary? The package will conflict with some other, already existing fedora packages due to the overly generic names for these binaries. Fabio > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
