Hi,
Phil Sutter <psutter@xxxxxxxxxx> writes:
> Hi,
>
> On Tue, Oct 08, 2019 at 01:23:01PM +0100, Tomasz Kłoczko wrote:
>> On Tue, 8 Oct 2019 at 12:58, <notifications@xxxxxxxxxxxxxxxxx> wrote:
>>
>> > Notification time stamped 2019-10-08 11:54:56 UTC
>> >
>> > From 26d638db91fa316f706ea947ab076bce216ec8cc Mon Sep 17 00:00:00 2001
>> > From: Phil Sutter <psutter@xxxxxxxxxx>
>> > Date: Oct 08 2019 11:51:27 +0000
>> > Subject: iproute-5.3.0-2
>> >
>> >
>> > - ifcfg script uses killall, therefore requires psmisc package
>> >
>>
>> IMO that fix is fundamentally wrong.
>
> Thanks for the heads-up. Maybe Ondřej might tell us the reason for the
> new dependency (it was his pull-request I merged).
I just happened to run ifcfg on a system that did not have killall
installed and noticed an error message about killall missing. I don't
really have a use case for ifcfg; I just noticed a bug and fixed it.
ifcfg uses killall, so the iproute package must Require it. The fix is
obviously correct, not fundamentally wrong. Tomasz appears to be arguing
that systemctl should be used instead of killall, which is of course a
completely separate issue. Feel free to fix that upstream, Tomasz.
Regards,
Ondra
>
>> Instead using killall it should be used systemd to reload service
>> ("systenctrl reload rdisc").
>
> I guess users preferring to use ifcfg for interface configuration over
> NetworkManager also don't care about rdisc systemd unit.
>
>> Why? In case of using LXC or other containerisation ifcfg which will be
>> using killal and used from global zone/namespace will cause to reload
>> all rdisc (those running in containers as well).
>
> Is this a theoretical point or to you know of any real use-case where
> ifcfg is used? If so, what's the reason for not using nmcli?
>
>> Next is that rdisc is part of the iputils which is not listed in list of
>> iproure dependencies (I'm not sure is it correct to add that dependency but
>> seems it is legit).
>>
>> Other thing is that ifcfg script is bash dependent because
>>
>> $ grep -w local /usr/sbin/ifcfg
>> local sbase fwd
>> local class;
>
> So sounds like even more dependencies are required to be formally
> correct. Maybe this even justifies putting ifcfg (and probably other
> shell scripts as well) into a dedicated sub-package to not impose too
> many dependencies onto the core iproute package.
>
>> Those two lines can be removed without harming anything to make that script
>> full POSIX sh compliant (and still working correctly with bash as
>> /usr/bin/sh).
>
> Feel free to submit a patch upstream. Sadly these scripts are not very
> well maintained, probably just because hardly anyone uses them.
>
>> BTW. Looks like no one in Fedora have been looking on all cases like above
>> to have proper separation between zones/container/namespaces.
>
> Not just in Fedora, it seems. ;)
>
> Cheers, Phil
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
