On 6/18/19 3:56 PM, Florian Weimer wrote:
* Panu Matilainen:
So if you have
%if 1 == 1
echo moo
%else # %define aaa bbb
echo foo
%endif # %define aaa ccc
...the value of aaa macro is actually bbb after parsing this. Those
%define's could also be there without the comment marks and behave the
same deed.
So the new warning has to look at the line *before* expanding it, so a
macro wont help with that. Rpm could of course specifically handle #
-comments there, but for consistency it should allow free # -comments
everywhere then.
Not sure if I understand. Are you saying that
%endif%{discard:__with_rebar3}
will not work either?
Yes, that's what I'm saying. Or rather, you'd get the warning with that
too. It all *behaves* exactly the same as before, so it continues to "work".
- Panu -
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
