On Thu, 2019-06-13 at 12:42 -0400, Neal Gompa wrote:
> > > > This is wrong (not sure if the culprit)
> > > >
> > > > %endif %{__with_rebar3}
> > > >
> > > > I would rewrite it to:
> > > >
> > > > %endif # __with_rebar3
> > >
> > > Actually both are wrong, and rpm >= 4.15 will complain (unlike old
> > > versions). Rpm only supports comments at beginning of line, and this
> > > only ever worked by accident.
> >
> > Oh dear, that's unfortunate. Because of the lack of indentation,
> > parsing a nested set of %ifs in spec files has always been difficult,
> > and adding an end-of-line comment after the %endif to help is
> > definitely a pattern I've seen in multiple spec files.
>
> I guess people don't know you can indent conditional blocks? It's the
> only indentation rpmbuild allows, but you can do it.
Well, I for one sure didn't...
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
