On Fri, May 31, 2019 at 1:22 PM Jan Pazdziora <jpazdziora@xxxxxxxxxx> wrote:
On Fri, May 31, 2019 at 12:53:35PM +0200, Jan Tulak wrote:
> Hi guys
>
> I'm trying to enable gating tests for package system-storage-manager.
> The tarball contains upstream tests and I would like to use these
> (with the ability to apply patches to them, same as to the rest of the
> code). I have a gating.yaml and tests.yml that works in RHEL exactly
> as I want it, but when I try to apply them to Fedora, I can't get it
> to work.
>
> It looks as the tests are not included in the VM built for the test.
> If I change tests.yml and use only "run: some_system_command," then
> the system command is executed.
>
> My tests.yml looks very similar to swid-tools, where it works
> (according to jenkins logs), so I'm cc-ing Jan Pazdziora just in case.
>
> I tried to find some solution on
> https://docs.fedoraproject.org/en-US/ci/ (and subpages), but if it is
> there, I didn't notice. I also found some other pages as
> https://docs.pagure.org/greenwave/package-specific-policies.html, with
> the same result.
>
> I'm using this PR to start the tests:
> https://src.fedoraproject.org/rpms/system-storage-manager/pull-request/1
> A failed run: https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/fedora-f30-pr-pipeline/detail/fedora-f30-pr-pipeline/102/pipeline
>
> Any ideas what I'm doing wrong? gating.yaml and tests.yml bellow.
[2019-05-31T08:59:54.127Z] stdout: |-
[2019-05-31T08:59:54.127Z] Test: smoke
[2019-05-31T08:59:54.127Z] Command: ./test.py --system --logs
[2019-05-31T08:59:54.127Z] Work dir: /var/str/source
[2019-05-31T08:59:54.127Z] Artifacts dir: /tmp/artifacts
[2019-05-31T08:59:54.127Z] Timeout: 0
[2019-05-31T08:59:54.127Z] /usr/bin/env: python: No such file or directory
[2019-05-31T08:59:54.127Z] Run test 'smoke': done. Test's exit code: 127
[2019-05-31T08:59:54.127Z] smoke (problem with test execution)
Could the missing python be the culprit?
I didn't look too much at the code, but can you try to replace Shebang in upstream tests from unversioned python ( #!/usr/bin/env python ) to explicitly require either python2 or python3 ?
> --------------------------
> File gating.yml:
> --- !Policy
> product_versions:
> - fedora-*
> decision_context: bodhi_update_push_testing # was osci_compose_gate
> rules:
> - !PassingTestCaseRule {test_case_name: osci.brew-build.tier0.functional}
>
> I tried to replace the osci.brew-build.tier0.functional with some
> build.foo cases, but it didn't change anything.
I'd like to know how to enable gating in Fedora as well.
So far I've only seen example in
https://docs.fedoraproject.org/en-US/ci/gating/
which says
--- !Policy
product_versions:
- fedora-*
decision_context: bodhi_update_push_testing
rules:
- !PassingTestCaseRule {test_case_name: dist.depcheck}
but that test_case_name: dist.depcheck seems suspicious, it looks more
like a dependency check than gating based on the tests/tests.yaml
results.
I've found
https://src.fedoraproject.org/rpms/python-ansi2html/blob/master/f/gating.yaml
which says
- !PassingTestCaseRule {test_case_name: org.centos.prod.ci.pipeline.allpackages-build.package.test.functional.complete}
which sounds more related to the test result hostname
jenkins-continuous-infra.apps.ci.centos.org
-- but that
org.centos.prod.ci.pipeline.allpackages-build.package.test.functional.complete
does not seem to be documented anywhere, just used in a few
dist-git repositories.
Any hints about some better documentation about configuring gating for
Fedora would be appreciated.
--
Jan Pazdziora | adelton at #brno, #swid
Sr. Principal Software Engineer, Security Engineering, Red Hat
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
